From: Florian Müllner Date: Mon, 21 Nov 2016 17:09:42 +0000 (+0100) Subject: animations: Guard against empty animations X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~635 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e5101eb4072c3445ea2f029cc1abf774316351db;p=gnome-shell.git animations: Guard against empty animations Our animation code not only relies on the animation being loaded (which we handle), but also on having at least one frame - otherwise the computation of the next frame index will turn up NaN through division by zero. Guard against this case by treating empty animations as not loaded. https://bugzilla.gnome.org/show_bug.cgi?id=774805 --- diff --git a/js/ui/animation.js b/js/ui/animation.js index 23ec934d8..1ae9ba0ea 100644 --- a/js/ui/animation.js +++ b/js/ui/animation.js @@ -67,7 +67,7 @@ const Animation = new Lang.Class({ }, _animationsLoaded: function() { - this._isLoaded = true; + this._isLoaded = this._animations.get_n_children() > 0; if (this._isPlaying) this.play();